fix(llmcore): preserve exception chain on empty-response ConnectionError#662
Closed
Kailigithub wants to merge 1 commit into
Closed
fix(llmcore): preserve exception chain on empty-response ConnectionError#662Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this PR — it has been open for 19 days with no review activity. This change falls into the bot's B904 / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
except StopIterationblock in_stream(llmcore.py:388) re-raisedConnectionError("empty response")without preserving the original exception chain. Addingfrom eensures the traceback shows the full causal chain, which helps diagnose intermittent empty-response issues during LLM streaming.Changes
raise requests.ConnectionError("empty response")→raise requests.ConnectionError("empty response") from eOne-token change (
from e). TheConnectionErroris caught by the outer retry handler on line 390, so runtime behavior is unchanged — only the traceback quality improves.Verification
py_compile llmcore.py— passesruff check llmcore.py --select=B904— passes (was the only remaining B904 in the file)exc.__cause__is aStopIterationinstance after the fix